Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix imports filter #838

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Fix imports filter #838

merged 1 commit into from
Jul 14, 2021

Conversation

ShaiahWren
Copy link
Contributor

@app-sre-bot
Copy link
Collaborator

Can one of the admins verify this patch?

rochacbruno
rochacbruno approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@rochacbruno rochacbruno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 LGTM!

PS: fill the UI issue to implement the dropdown to send the state parameter :)

@newswangerd newswangerd added backport-4.2 This PR should be backported to stable-4.2 (1.2) backport-4.3 This PR should be backported to stable-4.3 (2.0) labels Jul 13, 2021
@ShaiahWren ShaiahWren force-pushed the fix-imports-filter branch 2 times, most recently from 9bf0d54 to 6a25239 Compare July 13, 2021 20:36
@ShaiahWren ShaiahWren merged commit 9e16307 into ansible:master Jul 14, 2021
@patchback
Copy link

patchback bot commented Jul 14, 2021 •
edited

Backport to stable-4.2: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.2/9e163074cd1662a366a5fef42c659779491ed0c6/pr-838

Backported as #839

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@ShaiahWren
Copy link
Contributor Author

Pr closed. :)

patchback bot pushed a commit that referenced this pull request Jul 14, 2021
@ShaiahWren
implement the state and keywords filter (#838)
770ca32 
Issue: AAH-646
(cherry picked from commit 9e16307)
@patchback patchback bot mentioned this pull request Jul 14, 2021
Merged
@patchback
Copy link

patchback bot commented Jul 14, 2021 •
edited

Backport to stable-4.3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.3/9e163074cd1662a366a5fef42c659779491ed0c6/pr-838

Backported as #840

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 14, 2021
@ShaiahWren
implement the state and keywords filter (#838)
f1b92c8 
Issue: AAH-646
(cherry picked from commit 9e16307)
@patchback patchback bot mentioned this pull request Jul 14, 2021
Merged
newswangerd pushed a commit that referenced this pull request Jul 19, 2021
@patchback @ShaiahWren
implement the state and keywords filter (#838) (#840)
e93d408 
Issue: AAH-646
(cherry picked from commit 9e16307)

Co-authored-by: Shaiah Emigh-Doyle <64337863+ShaiahWren@users.noreply.github.com>
newswangerd added a commit that referenced this pull request Jul 19, 2021
@patchback @ShaiahWren @newswangerd
implement the state and keywords filter (#838) (#839)
66a2d5b 
Issue: AAH-646
(cherry picked from commit 9e16307)

Co-authored-by: Shaiah Emigh-Doyle <64337863+ShaiahWren@users.noreply.github.com>
Co-authored-by: David Newswanger <dnewswan@redhat.com>
awcrosby added a commit to awcrosby/galaxy_ng that referenced this pull request Jul 20, 2021
@awcrosby
Revert "implement the state and keywords filter (ansible#838)"
555b501 
This reverts commit 9e16307.
awcrosby added a commit to awcrosby/galaxy_ng that referenced this pull request Jul 20, 2021
@awcrosby
Revert "implement the state and keywords filter (ansible#838)"
7a734ee 
This reverts commit 9e16307.
@newswangerd newswangerd added backported-4.2 This PR has been backported to stable-4.2 (1.2) backported-4.3 This PR has been backported to stable-4.3 (2.0) labels Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rochacbruno rochacbruno rochacbruno approved these changes

@newswangerd newswangerd newswangerd approved these changes

Assignees
No one assigned
Labels
backport-4.2 This PR should be backported to stable-4.2 (1.2) backport-4.3 This PR should be backported to stable-4.3 (2.0) backported-4.2 This PR has been backported to stable-4.2 (1.2) backported-4.3 This PR has been backported to stable-4.3 (2.0)
Projects
None yet
Milestone
No milestone
4 participants
@ShaiahWren @app-sre-bot @rochacbruno @newswangerd