Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

molecule needs ci added that includes fedora #1668

Closed
ssbarnea opened this issue Jan 16, 2019 · 5 comments
Closed

molecule needs ci added that includes fedora #1668

ssbarnea opened this issue Jan 16, 2019 · 5 comments
Labels
enhancement test Improvement to quality assurance: CI/CD, testing, building

Comments

@ssbarnea
Copy link
Member

Issue Type

  • Feature request

Desired Behavior

On openstack we recently we had to introduce testing with fedora-28 platform in addition to our centos-7 in order to prepare the entire chain for the forecoming rhel-8/centos-8 and we discovered a serious of problems with molecule, some fixed after PRs.

Still, this uncovers a much more problematic issue: molecule is not tested on CI with fedora images or VMs.

We need to introduce some minimal testing, at least of the docker images (fedora:28 and fedora:rawhide) in order to spot any possible bugs.

I know that travis has limited testing resources and this affected molecule so before proposing any change I will let the team to consider the best approach for increasing the testing coverage.

It would be enough to prepare an image to validate if it work, somethign that at this moment does not work because of fedora-cloud/docker-brew-fedora#62

@decentral1se
Copy link
Contributor

we discovered a serious of problems with molecule, some fixed after PRs.

Can you elaborate on the problems?

AFAIK, there is no Fedora support on Travis CI.

Any ideas here? I am not sure how this can be solved.

@ssbarnea
Copy link
Member Author

The purpose: validating the we can build a working molecule docker container based on fedora docker images. Recent bugs proved thart our default Dockerfile was flawed and needed patching in order to make it work on fedora systems.

We don't really need to run much, even an empty playbook would be enough to validate that the builded image worked and that we can connect to it.

See #1649 -- this being such an example. Now this ticket is about adding a CI test that would allow us to validate that this still works and avoid breaking it regardless if the breakage is caused by a change in molecule or a newer fedora container.

@webknjaz
Copy link
Member

@ssbarnea do you want to investigate setting it up under the Circle CI? This way we could load-balance our DDoS of CIs :)

@webknjaz webknjaz added enhancement test Improvement to quality assurance: CI/CD, testing, building labels Jan 24, 2019
@ssbarnea
Copy link
Member Author

You can test CentOS, Fedora and probably almost any OS using docker containers, including on Travis. There is no need for real VMs as testing containers works very well for this purpose.

@ssbarnea
Copy link
Member Author

I am closing this because now we test installation of the package in Fedora as part of tox "distros" environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement test Improvement to quality assurance: CI/CD, testing, building
Projects
None yet
Development

No branches or pull requests

3 participants