Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fedora images do lack a default command to run #62

Closed
ssbarnea opened this issue Jan 15, 2019 · 8 comments
Closed

fedora images do lack a default command to run #62

ssbarnea opened this issue Jan 15, 2019 · 8 comments
Assignees

Comments

@ssbarnea
Copy link
Contributor

This was initially reported on ansible/ansible#50951 as it was discovered while trying to test ansible-molecule on fedora sytems. With centos images it did work without any problem.

$ docker run -it fedora:28
docker: Error response from daemon: No command specified.

Running docker image inspect fedora:28 uncovered the fact that Cmd is null and this is what caused the issue. On CentOS image Cmd is /bin/bash.

Please fix this and rebuild images for fedora:28 and newer. Updating fedora:28 image is quite important as this is the base used by RHEL8/CentOS8 and the work being done for in preparation for these.

@cverna
Copy link
Collaborator

cverna commented Jan 16, 2019

This is weird we have the CMD set to /bin/bash see https://github.com/fedora-cloud/docker-brew-fedora/blob/master/Dockerfile#L17 and it used to work on previous images.

I ll investigate why the this is not working anymore

@cverna
Copy link
Collaborator

cverna commented Jan 16, 2019

@ssbarnea if this is blocking you in the mean time you can pull the base images from fedora registry, I just check and it works

$ podman run -it registry.fedoraproject.org/fedora:28
[root@6ede57ec4f8f /]# 

@cverna cverna self-assigned this Jan 16, 2019
@cverna
Copy link
Collaborator

cverna commented Jan 16, 2019

This is weird we have the CMD set to /bin/bash see https://github.com/fedora-cloud/docker-brew-fedora/blob/master/Dockerfile#L17 and it used to work on previous images.

I ll investigate why the this is not working anymore

So I think the error is that the dockerfile we use in the script to that generates the image did not have the CMD

I pushed ab933e7 to fix that and will prepare a new release. Depending on when the docker folks will review the change it should take ~1 day to be available in docker hub

@ssbarnea
Copy link
Contributor Author

@cverna Thanks for fixing this. Maybe you also want to update the test command to assure that you can run the container without a custom command -- jus to avoid accidental regression in the future.

Do you know how long it takes for the docker.io to be updated? I will try to reconfigure molecule to use fedora registry directly, I hope it can do that.

@cverna
Copy link
Collaborator

cverna commented Jan 16, 2019

@ssbarnea , I have opened docker-library/official-images#5302 now it is up to the docker team to review and merge the PR. It is generally does not take more than 1 day, I think the new image will be available tomorrow.

@cverna
Copy link
Collaborator

cverna commented Jan 17, 2019

@ssbarnea This should be now fixed, can you confirm and close the issue if that's the case ?

Thanks

@ssbarnea
Copy link
Contributor Author

ssbarnea commented Jan 17, 2019

Yes, it works and thanks for the help on this!

@cverna
Copy link
Collaborator

cverna commented Jan 17, 2019

No problem thanks for reporting the issue 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants