Improve Azure Driver

[lborguetti]

Guys,

This PR improves Azure Driver allowing to customize options like resource group name, location, vm size, image reference in the molecule configuration file.

Other improve is create the instance with Azure Managed Disk. The current driver does not remove the storage account created for the instance disk.

Example:

molecule/azure/molecule.yml
---
driver:
  name: azure
  location: eastus2
  resource_group_name: infra_test
platforms:
  - name: UbuntuServer16.04
    location: eastus2
    vm_size: Standard_A0
    image:
      offer: UbuntuServer
      publisher: Canonical
      sku: '16.04-LTS'
      version: latest

Let me know if this is useful.

Thanks,

[wilmardo]

First of all, thanks for the PR! I think @retr0h is busy at the moment but I can see one issue already, the PR is missing an update of the Cerberus schema validation.
Take a look at #1436 for some pointers @retr0h gave me how to implement this 👍

[retr0h]

Yes, what @wilmardo said.

[retr0h]

I'm going to hold off from merging this. As you know Ansible is adopting Molecule, therefore I do not want to merge anything that may impact future architectural decisions, as I will no longer be leading the development of this project.

[gundalow]

Once the repo has been moved under Ansible we can look at getting this merged.

In the short term we welcome testing and feedback on this PR.

Thanks for your understanding.

[lborguetti]

Thank you for the clarification.

[gundalow]

@lborguetti Hi, repo move is done, so I'm reviewing the PR backlog. I see from comment about from @wilmardo that "Cerberus schema validation" may need updating, could you please take a look at that?

[lborguetti]

@gundalow yes. I'll take a look.

Thanks,

[decentral1se]

Thanks @lborguetti, this looks solid and is a welcome change.

[decentral1se]

Maybe this is also said in #1491 (comment) but I think we now need to add a schema to validate this against as in https://github.com/ansible/molecule/blob/master/molecule/model/schema_v2.py. If so, there should also be some unit tests that verify validation works as expected.

[themr0c]

close/repopren to trigger travis build.

[ssbarnea]

I would gladly support this if it passes CI and once #1840 is addressed. Until then I will mark it as blocked. The only other option to merge it is if we can find cores that can test it on their own azure accounts.

[decentral1se]

Pushing out of next release as per #1491 (comment). Hope we can get moving on this soon but we're lacking some resources right now. It's on the stack!

[ssbarnea]

@lborguetti can you please fix the conflicts? If you do I will make sure I test it and merge it.

[ssbarnea]

I am closing this because code changed too much since it it was created and apparently the original uploader no longer active.

If the improvements are still desired please do them in small chucks, one improvement at a time. This makes easier to review and test, less likely to have conflicts. In the end merging all improvement in small chucks would be faster than in a single one.

For example few days ago I fixed the issue of using the harcoded region.