Add purge_networks arg to docker driver #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logan2211
force-pushed
the
docker-purge-networks
branch
from
228184e
to
a25ccfc
Compare
|
Hi @logan2211, thanks for your contribution! Please rebase this PR on top of master. |
|
Ping @logan2211! |
Users building containers in isolated docker networks may not want the default docker bridge network attached. Signed-off-by: Logan V <logan2211@gmail.com>
logan2211
force-pushed
the
docker-purge-networks
branch
from
a25ccfc
to
3f86540
Compare
|
Hi, sorry for the delay. This is rebased now. |
|
Again, this looks good and the CI failures are unrelated. Green CI builds coming soon ... |
This was referenced Jan 28, 2019
|
Added to agenda in ansible/community#427. Please join if you have time! |
themr0c
approved these changes
Jan 29, 2019
gundalow
reviewed
Jan 31, 2019
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users building containers in isolated docker networks may not want the
default docker bridge network attached.
This exposes the docker module's
purge_networksargument in the driver configuration.PR Type