Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove single quotes from docker example #1630

Closed
wants to merge 1 commit into from

Conversation

torrentalle
Copy link

This PR fixes the documentation issue #1629

$ docker run --rm -it \
>     -v $(pwd):/tmp/$(basename "${PWD}"):ro \
>     -v /var/run/docker.sock:/var/run/docker.sock \
>     -w /tmp/$(basename "${PWD}") \
>     quay.io/ansible/molecule:latest \
>     sudo molecule test
--> Validating schema /tmp/capside.cloudwatch-agent/molecule/default/molecule.yml.
Validation completed successfully.
--> Test matrix
    
└── default
    ├── lint
    ├── destroy
    ├── dependency
    ├── syntax
    ├── create
    ├── prepare
    ├── converge
    ├── idempotence
    ├── side_effect
    ├── verify
    └── destroy

PR Type

  • Docs Pull Request

Fix issue ansible#1629

Signed-off-by: Albert Moreno <albert.moreno@protonmail.com>
@decentral1se
Copy link
Contributor

Hey @torrentalle, thanks for the PR. Have you seen #1629 (comment)? It seems worth considering.

@themr0c themr0c added this to the v.2.21 milestone Jan 31, 2019
@decentral1se
Copy link
Contributor

The double quotes fix is handled in #1728.

@gundalow
Copy link
Contributor

gundalow commented Feb 6, 2019

@torrentalle Thanks for your fix, this would work through this might fail if the path has spaces in, I've just merged #1728 which fixes this by using double quotes

@gundalow gundalow closed this Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants