Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental --parallel functionality #2137

Merged

Conversation

decentral1se
Copy link
Contributor

@decentral1se decentral1se commented Jun 28, 2019

Supercedes the spike in #2135. Working towards closing #1702.

I've tried to incorporate comments from last review but as it's all a bit experimental, it was not possible to work them all in. However, I think this is a more elegant solution here. Ready for a review pass.

Q/A Testing much welcome (see "how to test" in #2135 (comment)).

/cc @ssbarnea @seandst @themr0c

Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a) Make sure user can define environment variable to enable parallel mode.
b) I do not fully understand why the new filter needs any parameters? cannot let the filter implementation take care of adding the uuid when needed?
c) I do have some concerns regarding effects on existing playbooks as people may use ansible fitlering based on hostname, I need to test it to see exactly what happens...

@decentral1se

This comment has been minimized.

@decentral1se
Copy link
Contributor Author

decentral1se commented Jul 1, 2019

Following from #2137 (comment), I've managed to internalise the entire workings of this now with e5ac12c. I use the new MOLECULE_STATE_FILE lookup to store the configuration (instead of passing it in manually into the playbook context) and hijack the from_yaml loading to re-apply the parallelization changes to the molecule.yml at run-time.

(I'll rebase all these fixups into a single commit once the review phase is over ...)

@ssbarnea ssbarnea merged commit 264cb90 into ansible:master Jul 4, 2019
@decentral1se decentral1se deleted the feature/parallelizable-sequences branch July 4, 2019 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants