Cache loaded drivers and adopt lru_cache #2259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caching loaded drivers has serious performance benefits, to have an idea running unit tests went from ~4min to 1.5mins. This change also replaces internal caching with stdlib lru_cache implementation. Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
Closed
ssbarnea
requested review from
decentral1se,
cloudnull,
LukeShortCloud and
gabrielecerami
decentral1se
approved these changes
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caching loaded drivers has serious performance benefits, to have an idea
running unit tests went from ~4min to 1.5mins.
This change also replaces internal caching with stdlib lru_cache
implementation.
Signed-off-by: Sorin Sbarnea ssbarnea@redhat.com
Please include details of what it is, how to use it, how it's been tested
Please include an entry in the CHANGELOG.md if the change will impact users.
PR Type