Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid futures SyntaxError #2291

Merged
merged 1 commit into from Sep 16, 2019
Merged

Avoid futures SyntaxError #2291

merged 1 commit into from Sep 16, 2019

Conversation

ssbarnea
Copy link
Member

Adds run-time check of future version to avoid later failures.
Fixes: #2181

decentral1se
decentral1se previously requested changes Sep 15, 2019
View reviewed changes
Copy link
Contributor

@decentral1se decentral1se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has commits from #2281?

@ssbarnea ssbarnea force-pushed the fix/futures branch 2 times, most recently from 47aad05 to 4705c34 Compare September 15, 2019 10:43
@ssbarnea ssbarnea added the bump label Sep 15, 2019
@ssbarnea ssbarnea added this to the 3.0 milestone Sep 15, 2019
decentral1se
decentral1se suggested changes Sep 15, 2019
View reviewed changes
molecule/command/init/role.py Outdated Show resolved Hide resolved
molecule/api.py Outdated Show resolved Hide resolved
decentral1se
decentral1se suggested changes Sep 15, 2019
View reviewed changes
Copy link
Contributor

@decentral1se decentral1se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather just not both with this ...

But if we must, let's give a better error message.

molecule/shell.py Outdated Show resolved Hide resolved
decentral1se
decentral1se suggested changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@decentral1se decentral1se left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My typo!

😅

molecule/shell.py Outdated Show resolved Hide resolved
@ssbarnea
Avoid futures SyntaxError
ad1a5a6 
Adds runtime check of future version to avoid later runtime failures.

See agronholm/pythonfutures#90

Fixes: ansible#2181

Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
@decentral1se decentral1se merged commit b116700 into ansible:master Sep 16, 2019
@ssbarnea ssbarnea deleted the fix/futures branch October 19, 2019 17:23
@ssbarnea ssbarnea added bug and removed .bump labels Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decentral1se decentral1se decentral1se approved these changes

@cloudnull cloudnull Awaiting requested review from cloudnull

@jctanner jctanner Awaiting requested review from jctanner

@LukeShortCloud LukeShortCloud Awaiting requested review from LukeShortCloud

@themr0c themr0c Awaiting requested review from themr0c

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

presence of futures==3.1.1 can break molecule
2 participants
@ssbarnea @decentral1se