Reverts setuptools workaround #2384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on local testing this seems to address installation failures like ones throwing BackendUnavailable. Keep in mind that pyproject.toml build-system section is used only with recent packaging tools and only for building the wheel. Older systems do rely only on packaging data from already build wheel. Fixes: ansible#2386 Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
ssbarnea
force-pushed
the
fix/packaging
branch
from
98d3cf3
to
fa4de1c
Compare
decentral1se
approved these changes
Oct 20, 2019
Keep the antiviperin syringe close, just in case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes back to
setuptools >= 41.0.0for build time as missing to mentionit would generate a failure to install from source in editable mode.