test: prevent running functional tests when not installed #2482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
added
test
sshnaidm
suggested changes
Jan 4, 2020
ssbarnea
force-pushed
the
master
branch
2 times, most recently
from
df471de
to
b21671f
Compare
sshnaidm
approved these changes
Jan 5, 2020
Running functional tests require molecule package to be installed, so we now test for it and fail fast the testing if needed. This should simplify development by avoiding confusing errors in individual tests. Only functional tests are affected so we apply this requirement only to them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running functional tests require molecule package to be installed, so
we now test for it and fail fast the testing if needed.
This should simplify development by avoiding confusing errors in
individual tests. Only functional tests are affected so we apply this
requirement only to them.