WIP: Remove ansible-lint < 5 restriction #3060
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added in ansible#1675 and no longer seems to be necessary. Version `5` of `ansible-lint` is stable and not incompatible with `molecule`. Since `ansible-lint` must be installed with the `[community]` extra in version `5`, this makes version `5` the new minimum version, to ensure the `[community]` extra is not applied to version `4`.
|
Please don't merge this yet. I'm discovering several significant bugs with |
ssbarnea
approved these changes
Mar 1, 2021
decentral1se
changed the title
|
Closing as master already used version v5. If you have bugs you can avoid using lint extra and manually specify requirements. Also be sure you report problems to the linter, preferably with pull-requests too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added in #1675 and no longer seems to be necessary. Version
5ofansible-lintis stable and not incompatible withmolecule.Since
ansible-lintmust be installed with the[community]extra in version5, this makes version5the new minimum version, to ensure the[community]extra is not applied to version4.PR Type