Put 'directory' attribute back into schema

[davedittrich]

PR #3638 removed a central part of the schema that broke pytest-testinfra. I am assuming that a test for this was also removed, hence the unnoticed regression. I spent a little time looking into it and it looked like the schema validation is more a "does it parse" than "does it support all possible attributes."

[davedittrich]

Actually, it does look like a unit test was also broken: src/molecule/test/unit/model/v2/test_verifier_section.py

https://github.com/ansible-community/molecule/pull/3638/files

I do not know how to run unit tests to verify that simply putting the "directory" attribute back in will work, but it looks like this should be done as well.

[jsf9k]

I am hitting this issue as well, for example here. More generally, this issue is breaking all of our Ansible role builds that use a non-default location for the Molecule testinfra test code.

[jsf9k]

Resolves #3686

[ssbarnea]

@jsf9k You forgot to rebase it

[jsf9k]

@jsf9k You forgot to rebase it

@ssbarnea - The PR was created by @davedittrich, not me.

@davedittrich - Can you rebase the PR? I doubt I have permissions to do that.

[jsf9k]

@davedittrich - Can you rebase the PR? I doubt I have permissions to do that.

I was able to successfully rebase locally (there were no conflicts), but as expected I lack the necessary permissions to force push to @davedittrich's branch.

[davedittrich]

@jsf9k There you go! Thanks!

[jsf9k]

@davedittrich closed this PR, so I assume his intent is that I create a new one from the rebased branch. I did just that in PR #3687.

[davedittrich]

@jsf9k Sorry about that. My mistake. I thought everything was complete and misread the GitHub suggestions about being able to delete the branch. I'm glad you moved forward as you did. Thanks!