Pytest 4 1 compliant #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
original warning message raise during test: /perso/pytest-ansible/tests/conftest.py:68: RemovedInPytest4Warning: usage of Function.Function is deprecated, please use pytest.Function instead
Original warning message raise durig tests: /pytest-ansible/tests/test_module_result.py:119: RemovedInPytest4Warning: getfuncargvalue is deprecated, use getfixturevalue
Original warning message raise durig tests: tests/test_module_dispatcher.py:32: RemovedInPytest4Warning: Applying marks directly to parameters is deprecated, please use pytest.param(..., marks=...) instead. For more details, see: https://docs.pytest.org/en/latest/parametrize.html @pytest.mark.parametrize("host_pattern, num_hosts", POSITIVE_HOST_PATTERNS)
previously the test was expecting EXIT_INTERRUPTED return code but pytest actualy returns EXIT_USAGEERROR return code
the test was failling because more than one warning was raised. Instead of to test the number of warning (wich is IMHO just to avoid exception when testing message if no warning was raised ) we test that at leat one warning with the message 'provided hosts list is empty, only localhost is available' has been raised
…node.get_marker(...) Original warning message raise durig tests: _pytest.warning_types.RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly. Please use node.get_closest_marker(name) or node.iter_markers(name). Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
|
@vgramer This is great, thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix the tests in order to be compliant with pytest 4.1
I have split the PR in many commits in order make the review easier. I can squash the commits if you wish.
Please pay attention to commit b65d104 beacause i haven't find a doc that explain why this return code has changed. The new return code
EXIT_USAGEERRORseems logic to me but ...The tests on
ansible_develare failing because of a breaking change on ansible python API.CLI.base_parser()does not exist anymore