Capture module failure in class ModuleResult #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose M. Prieto <jose.prieto@roche.com>
If module fails the callback plugin captures the event by adding fields "rc" and "failed" to the return dict so that properties like "is_failed" later on returns True Signed-off-by: Jose M. Prieto <jose.prieto@roche.com>
Signed-off-by: Jose M. Prieto <jose.prieto@roche.com>
Pull Request Test Coverage Report for Build 210
💛 - Coveralls |
|
👋 hello this looks pretty good. I'd like to give this project a bit of care and feeding (fix up CI) and maybe get a release out next week sometime. Let me see how far I get and we can try and get this merged and in that release. |
|
As is evident, i did not get very far. Let's merge this and work from there. |
kdelee
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I am using pytest_ansible in one of my projects. In particular I am using pytest_ansible to test an action plugin I have developed. However, during the development of my negative test cases, I found the property
is_failedin classModuleResultis not catching the module failure due to the fact the classResultAccumulator(the callback plugin capturing ansible result during test execution) did not include the keyfailedwithinModuleResult. This PR includes just a few modifications based in version 2.2.2 which fix basically that allowing me now to assert on for instancecontacted.localhost.is_failedupon a module error.Cheers
Jose M. Prieto