Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support extra inventory in pytest-ansible #64

Merged
merged 1 commit into from
Aug 31, 2022
Merged

support extra inventory in pytest-ansible #64

merged 1 commit into from
Aug 31, 2022

Conversation

CFSNM
Copy link
Collaborator

@CFSNM CFSNM commented Aug 19, 2022

No description provided.

@CFSNM CFSNM marked this pull request as draft August 19, 2022 12:57
@CFSNM CFSNM force-pushed the add_extra_inventory branch 8 times, most recently from fff3aef to 8a65137 Compare August 26, 2022 09:22
@CFSNM CFSNM marked this pull request as ready for review August 29, 2022 11:11
@CFSNM CFSNM force-pushed the add_extra_inventory branch 2 times, most recently from 228bfa3 to b39d93b Compare August 29, 2022 15:08
@kdelee
Copy link
Member

kdelee commented Aug 29, 2022 •
edited
Loading

@CFSNM can you make another PR to drop python 2.7 from tox.ini and setup.py?
also bump the version to 2.3.0 in https://github.com/ansible-community/pytest-ansible/blob/6649dd5d02337e4ebccb9f288f751364ea00754f/pytest_ansible/__init__.py#L3 since this will be a breaking change to drop support for python 2

If I was you I'd add python 3.9 as well to tox.ini and setup.py -- though for tox I'd just do it for ansible 2.9

I think we need to get CI passing on devel

sooner than later we need to get this working with modern ansible (e.g. 2.10+) but that can be a seperate work item

@CFSNM CFSNM force-pushed the add_extra_inventory branch 3 times, most recently from de866cb to 6d856ce Compare August 31, 2022 07:09
@kdelee kdelee changed the title Draft to support extra inventory in pytest-ansible support extra inventory in pytest-ansible Aug 31, 2022
@kdelee kdelee merged commit 434de9c into ansible:master Aug 31, 2022
@CFSNM CFSNM deleted the add_extra_inventory branch August 31, 2022 12:47
@ssbarnea ssbarnea added bug and removed bug labels Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdelee kdelee kdelee approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CFSNM @kdelee @ssbarnea