Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add consider-using-f-string check #90

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Conversation

Ruchip16
Copy link
Member

@Ruchip16 Ruchip16 commented Apr 6, 2023

The f-string check makes sure that we use f-strings instead of the traditional string formatting method. The traditional string formatting method involves using the % operator or the .format() method to insert values into a string. However, using f-strings can make our code more readable, especially when dealing with complex string formatting operations.

CC: @ssbarnea @cidrblock

Related to #85

@Ruchip16 Ruchip16 added the bug label Apr 6, 2023
@Ruchip16 Ruchip16 requested a review from a team as a code owner April 6, 2023 09:46
@Ruchip16 Ruchip16 self-assigned this Apr 6, 2023
@Ruchip16 Ruchip16 requested review from ssbarnea, ganeshrn, shatakshiiii, priyamsahoo and cidrblock and removed request for a team April 6, 2023 09:46
@Ruchip16 Ruchip16 changed the title Fix for consider-using-f-string Add consider-using-f-string check Apr 6, 2023
Copy link

@priyamsahoo priyamsahoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@priyamsahoo priyamsahoo merged commit adbeafc into ansible:main Apr 6, 2023
@Ruchip16 Ruchip16 deleted the fix/fstring branch April 6, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants