Add no-else-raise check
#92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruchip16
requested review from
ganeshrn,
trishnaguha,
cidrblock,
priyamsahoo and
ssbarnea
and removed request for
a team
ssbarnea
reviewed
Apr 11, 2023
ssbarnea
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
no-else-raisecheck ensures that there is no unnecessaryelsestatement in the code block following araisestatement. As the raise statement causes an exception to be thrown, any code following the raise statement will not be executed, which makes the else block redundant and hence this check ensures that there is no else block after a raise statement. It helps to make our code readable amd modular.Related to #85