Add super-with-arguments & too-few-public-methods check
#95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruchip16
requested review from
ganeshrn,
trishnaguha,
cidrblock,
ssbarnea,
priyamsahoo,
a team and
shatakshiiii
and removed request for
a team
audgirka
approved these changes
Apr 13, 2023
ssbarnea
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
super-with-argumentserror is a linting error that occurs when calling thesuper()function with arguments. In Python 3, it's recommended to use the super() function without arguments, as it will automatically infer the correct superclass and arguments.The
too-few-public-methodcheck indicates that the class has very few public methods and may not be well-designed for reuse or extension. To fix this error, we need to refactor the class to add more public methods or convert it into a module or a function if it's not needed as a class. For now I have added the#pylintcomment for it but in future we can try to refactor the code which can make it more modular. @ssbarnea @cidrblockRelated to #85