Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added tests for workceptor.go #922

Merged
merged 1 commit into from Jan 17, 2024
Merged

Conversation

resoluteCoder
Copy link
Contributor

Added more test coverage for the workceptor.go file

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1d24d12) 35.52% compared to head (4865015) 38.15%.

@@            Coverage Diff             @@
##            devel     #922      +/-   ##
==========================================
+ Coverage   35.52%   38.15%   +2.63%     
==========================================
  Files          40       40              
  Lines        7452     7452              
==========================================
+ Hits         2647     2843     +196     
+ Misses       4652     4449     -203     
- Partials      153      160       +7     
Files Coverage Δ
pkg/workceptor/workceptor.go 50.44% <100.00%> (+30.66%) ⬆️

... and 5 files with indirect coverage changes

@resoluteCoder resoluteCoder force-pushed the workceptor branch 2 times, most recently from 9de57bd to b80f977 Compare January 16, 2024 21:02
Copy link

sonarcloud bot commented Jan 16, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

7 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@resoluteCoder resoluteCoder force-pushed the workceptor branch 2 times, most recently from 9c62204 to 5363eb5 Compare January 16, 2024 21:15
@resoluteCoder resoluteCoder force-pushed the workceptor branch 3 times, most recently from 8beee00 to 58248ab Compare January 17, 2024 15:32
Copy link

sonarcloud bot commented Jan 17, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@AaronH88 AaronH88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AaronH88 AaronH88 merged commit 0310885 into ansible:devel Jan 17, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants