CI fixes #1026

goneri · 2023-12-06T18:22:09Z

No description provided.

goneri · 2023-12-06T23:25:52Z

@ganeshrn it looks like something is wrong with EE and MacOS.

ganeshrn · 2023-12-07T11:36:08Z

@goneri The macos ci job is flaky and fails intermittently. We can ignore that failure.

tools/test-setup.sh

Prettier 3 and 4 are not formatting the block the same way. This change simpifies the logic and avoid any trouble during the migration to prettier 4.

With need to prepare the venv before running the tests.

The following syntax for the `cmds` fields doesn't work as expected and the first line triggers a failure. The venv envvars are never properly initialized. ``` - > source "${VIRTUAL_ENV}/bin/activate" && yarn run test-e2e ```

audgirka

@ganeshrn Looks good to me. Let me know if we can merge this

ganeshrn · 2023-12-08T08:57:24Z

@goneri Thanks for working on this.

GHA: Cache the ~/.cache/pre-commit/ directory

a75cfc3

goneri requested a review from a team as a code owner December 6, 2023 18:22

goneri requested review from ssbarnea and Qalthos December 6, 2023 18:22

goneri had a problem deploying to ack December 6, 2023 18:22 — with GitHub Actions Failure

goneri had a problem deploying to ack December 6, 2023 19:29 — with GitHub Actions Failure

goneri force-pushed the pre-commit branch from 02ee7a3 to d14ca1d Compare December 6, 2023 19:44

goneri had a problem deploying to ack December 6, 2023 19:44 — with GitHub Actions Failure

goneri force-pushed the pre-commit branch from d14ca1d to c9b711e Compare December 6, 2023 19:48

goneri had a problem deploying to ack December 6, 2023 19:48 — with GitHub Actions Failure

goneri had a problem deploying to ack December 6, 2023 20:18 — with GitHub Actions Failure

goneri had a problem deploying to ack December 6, 2023 20:26 — with GitHub Actions Failure

goneri had a problem deploying to ack December 6, 2023 20:39 — with GitHub Actions Failure

goneri had a problem deploying to ack December 6, 2023 21:00 — with GitHub Actions Failure

goneri force-pushed the pre-commit branch from 1cef7a8 to 7eb99b4 Compare December 6, 2023 21:25

goneri had a problem deploying to ack December 6, 2023 21:25 — with GitHub Actions Failure

goneri had a problem deploying to ack December 6, 2023 22:16 — with GitHub Actions Failure

goneri force-pushed the pre-commit branch from 151cac0 to 5479cfe Compare December 6, 2023 22:17

goneri had a problem deploying to ack December 6, 2023 22:17 — with GitHub Actions Failure

goneri had a problem deploying to ack December 6, 2023 22:22 — with GitHub Actions Failure

goneri had a problem deploying to ack December 6, 2023 22:30 — with GitHub Actions Failure

goneri had a problem deploying to ack December 6, 2023 22:35 — with GitHub Actions Failure

goneri force-pushed the pre-commit branch from 2a6d337 to 1bba7ab Compare December 6, 2023 22:40

goneri had a problem deploying to ack December 6, 2023 22:40 — with GitHub Actions Failure

goneri had a problem deploying to ack December 6, 2023 22:45 — with GitHub Actions Failure

goneri force-pushed the pre-commit branch from 8751b88 to b7f55ea Compare December 6, 2023 23:06

goneri had a problem deploying to ack December 6, 2023 23:06 — with GitHub Actions Failure

goneri changed the title ~~Pre commit~~ CI fixes Dec 6, 2023

goneri force-pushed the pre-commit branch from f725b45 to 86bbd86 Compare December 7, 2023 16:55

goneri had a problem deploying to ack December 7, 2023 16:55 — with GitHub Actions Failure

goneri force-pushed the pre-commit branch from 86bbd86 to af7ef24 Compare December 7, 2023 17:01

goneri had a problem deploying to ack December 7, 2023 17:01 — with GitHub Actions Failure

goneri force-pushed the pre-commit branch from af7ef24 to 5cc5e5f Compare December 7, 2023 17:07

goneri had a problem deploying to ack December 7, 2023 17:07 — with GitHub Actions Failure

goneri force-pushed the pre-commit branch from 5cc5e5f to c5625df Compare December 7, 2023 17:18

goneri had a problem deploying to ack December 7, 2023 17:18 — with GitHub Actions Failure

goneri force-pushed the pre-commit branch from c5625df to 9c1557e Compare December 7, 2023 17:21

goneri had a problem deploying to ack December 7, 2023 17:21 — with GitHub Actions Failure

goneri had a problem deploying to ack December 7, 2023 17:32 — with GitHub Actions Failure

ssbarnea reviewed Dec 7, 2023

View reviewed changes

tools/test-setup.sh Outdated Show resolved Hide resolved

GH/ci: fails on test error

ef8a6a0

goneri force-pushed the pre-commit branch from 86219a6 to 8ca26d1 Compare December 7, 2023 19:54

goneri had a problem deploying to ack December 7, 2023 19:55 — with GitHub Actions Failure

goneri added 3 commits December 7, 2023 14:55

testRunner: expand the logic used to find the platform name

5de559c

Prettier 3 and 4 are not formatting the block the same way. This change simpifies the logic and avoid any trouble during the migration to prettier 4.

GHA: CI ignore error on MacOS

e270f15

GHA/test: setup is a dependency

f177a2a

With need to prepare the venv before running the tests.

goneri force-pushed the pre-commit branch from 8ca26d1 to f177a2a Compare December 7, 2023 19:56

goneri had a problem deploying to ack December 7, 2023 19:56 — with GitHub Actions Failure

task: inline the venv activate and the command

9f45989

The following syntax for the `cmds` fields doesn't work as expected and the first line triggers a failure. The venv envvars are never properly initialized. ``` - > source "${VIRTUAL_ENV}/bin/activate" && yarn run test-e2e ```

goneri had a problem deploying to ack December 7, 2023 20:05 — with GitHub Actions Failure

goneri mentioned this pull request Dec 8, 2023

lightspeed: use the code value from the 403 #1024

Merged

audgirka added the skip-changelog label Dec 8, 2023

audgirka temporarily deployed to ack December 8, 2023 07:02 — with GitHub Actions Inactive

audgirka approved these changes Dec 8, 2023

View reviewed changes

audgirka requested a review from ssbarnea December 8, 2023 08:34

audgirka merged commit 55caa4c into ansible:main Dec 8, 2023
7 of 8 checks passed

goneri mentioned this pull request Dec 8, 2023

lightspeed: a unit-test for the error handling #1028

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CI fixes #1026

CI fixes #1026

goneri commented Dec 6, 2023

goneri commented Dec 6, 2023

ganeshrn commented Dec 7, 2023

audgirka left a comment

ganeshrn commented Dec 8, 2023

CI fixes #1026

CI fixes #1026

Conversation

goneri commented Dec 6, 2023

goneri commented Dec 6, 2023

ganeshrn commented Dec 7, 2023

audgirka left a comment

Choose a reason for hiding this comment

ganeshrn commented Dec 8, 2023