Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable Lightspeed UI tests #1088

Merged
merged 9 commits into from
Mar 4, 2024
Merged

Re-enable Lightspeed UI tests #1088

merged 9 commits into from
Mar 4, 2024

Conversation

TamiTakamiya
Copy link
Collaborator

@TamiTakamiya TamiTakamiya commented Feb 9, 2024 •
edited

Re-enable Lightspeed UI tests, which have been commented out and not executed for a while. Changes include:

  • Applied changes corresponding to the latest Lightspeed code base (e.g. side panel section name: "Ansible Lightspeed" --> "Ansbile Lightspeed Login")
  • Replaced a few vscode-extension-tester fucntions, which seemed not working as expected, with findElement/findElements calls with XPath locators. Although this might be somehow controversial one, I think this is a realistic approach for writing reliable UI tests for VS Code now.
  • Intentionally kept original codes for the reference purpose. We may want to clean them up in the future.

Codes were tested with yarn test-ui-current command. yarn test-ui-oldest fails due to current extension's vscode version requirement.

@TamiTakamiya TamiTakamiya added the bug Something isn't working label Feb 9, 2024
@TamiTakamiya TamiTakamiya marked this pull request as ready for review February 9, 2024 17:04
@TamiTakamiya TamiTakamiya requested a review from a team as a code owner February 9, 2024 17:04
@TamiTakamiya TamiTakamiya force-pushed the TamiTakamiya/enable-lightspeed-ui-tests branch from da40d93 to 6fb09d8 Compare February 12, 2024 13:17
@TamiTakamiya TamiTakamiya mentioned this pull request Feb 12, 2024
Merged
@TamiTakamiya TamiTakamiya force-pushed the TamiTakamiya/enable-lightspeed-ui-tests branch from fc6d42d to ebbaa42 Compare February 29, 2024 05:33
@TamiTakamiya TamiTakamiya requested review from goneri and removed request for cristianonicolai March 4, 2024 14:34
@TamiTakamiya TamiTakamiya merged commit 93e9d57 into main Mar 4, 2024
8 of 9 checks passed
@TamiTakamiya TamiTakamiya deleted the TamiTakamiya/enable-lightspeed-ui-tests branch March 4, 2024 15:09
@TamiTakamiya TamiTakamiya mentioned this pull request Mar 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea left review comments

@goneri goneri goneri approved these changes

@ganeshrn ganeshrn ganeshrn approved these changes

@Qalthos Qalthos Awaiting requested review from Qalthos Qalthos is a code owner automatically assigned from ansible/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo

Assignees
No one assigned
Labels
bug Something isn't working
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TamiTakamiya @goneri @ssbarnea @ganeshrn