Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment crediting Ansible Lightspeed to suggestion ghost text #1117

Merged
merged 8 commits into from
Mar 12, 2024

Conversation

robinbobbitt
Copy link
Contributor

@robinbobbitt robinbobbitt commented Mar 6, 2024

When users have more than one inline suggestion provider configured in their VS Code, it can be hard to know which suggestion came from Lightspeed. With this PR, we add "# Content suggestion provided by Ansible Lightspeed" as a first line in the ghost text. We also add a setting that determines if this comment should be retained in the suggestion when the user accepts it. Thank you to @ganeshrn for sharing a first cut of this feature.

Related: microsoft/vscode#205555

Copy link
Collaborator

@TamiTakamiya TamiTakamiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@ssbarnea ssbarnea changed the title add comment crediting Ansible Lightspeed to suggestion ghost text Add comment crediting Ansible Lightspeed to suggestion ghost text Mar 12, 2024
@ssbarnea ssbarnea disabled auto-merge March 12, 2024 15:34
@ssbarnea ssbarnea merged commit a86aea3 into main Mar 12, 2024
9 checks passed
@ssbarnea ssbarnea deleted the AAP-20563 branch March 12, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants