-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt ansible-language-server as a workspace #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix EE auto-completion not working issue * Currently fetch plugin from EE requires ansibleConfig service to be invoked to identify the path within EE that contains ansible plugins * Also docLibrary service invokes ansibleConfig service thus duplicating the call * The PR refactors the code to invoke fetching EE plugin docs from within docsLibrary service and thus avoiding multiple async invocation of ansibleConfig service * add changelog * chore: auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ype (#276) * provide '-' when option or suboption is a list * replace double quotes with single quotes after latest merge * add logic for appropriate resolution of module options and suboptions based on their types * add double tabs on resolution of dict to avoid wrong autocompletion if the first element of the list is dict * add basic structure for doResolveCompletion test * update quotations * remove ':' after option name when not found at end of line while resolution * add test fixture of doCompletionResolve() tests * update tests for doCompletionResolve() * add type for parameter in resolveSuffix function * chore: auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix linting * add change note * add ability to give default insertText when 'type' is not present for module options * add utility function to add data if an option or module name is the first element of list or not * call resolveSuffix for module name by sending type as 'dict' for them * update test script and fixture with latest changes in doCompletionResolve() Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Ganesh Nalawade <ganesh634@gmail.com>
Bumps [click](https://github.com/pallets/click) from 8.1.0 to 8.1.1. - [Release notes](https://github.com/pallets/click/releases) - [Changelog](https://github.com/pallets/click/blob/main/CHANGES.rst) - [Commits](pallets/click@8.1.0...8.1.1) --- updated-dependencies: - dependency-name: click dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ansible-core](https://github.com/ansible/ansible) from 2.12.3 to 2.12.4. - [Release notes](https://github.com/ansible/ansible/releases) - [Commits](ansible/ansible@v2.12.3...v2.12.4) --- updated-dependencies: - dependency-name: ansible-core dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
* Generate a changelog entry for v0.5.4 * Release 0.5.4 from GitHub Actions CI/CD * chore: auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Autocomplete option and suboption choices * chore: auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix tests & add more * Fix tests * Add changelog fragment * chore: auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Ganesh Nalawade <ganesh634@gmail.com>
Bumps [pre-commit](https://github.com/pre-commit/pre-commit) from 2.17.0 to 2.18.1. - [Release notes](https://github.com/pre-commit/pre-commit/releases) - [Changelog](https://github.com/pre-commit/pre-commit/blob/main/CHANGELOG.md) - [Commits](pre-commit/pre-commit@v2.17.0...v2.18.1) --- updated-dependencies: - dependency-name: pre-commit dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
updates: - [github.com/streetsidesoftware/cspell-cli: v5.8.4 → v5.9.0](streetsidesoftware/cspell-cli@v5.8.4...v5.9.0) - [github.com/pre-commit/mirrors-prettier: v2.5.1 → v2.6.2](pre-commit/mirrors-prettier@v2.5.1...v2.6.2) - [github.com/pre-commit/mirrors-eslint: v8.10.0 → v8.12.0](pre-commit/mirrors-eslint@v8.10.0...v8.12.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Sorin Sbarnea <ssbarnea@redhat.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Bumps [click](https://github.com/pallets/click) from 8.1.1 to 8.1.2. - [Release notes](https://github.com/pallets/click/releases) - [Changelog](https://github.com/pallets/click/blob/main/CHANGES.rst) - [Commits](pallets/click@8.1.1...8.1.2) --- updated-dependencies: - dependency-name: click dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Move glob utils to different utils file * Move glob utils function into a path utils file * Remove commented out code * chore: auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add changelog file * fix ci failure and rename test file Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Add vscode extension e2e test in CI * Add CI job to run test-e2e suite from vscode-ansible extension to ensure changes in PR does not break vscode-ansible extension * add new line * Update vscode.yml * update vscode workflow * install ansible-language-server dependecies * install test dependecies * update test name Co-authored-by: Sorin Sbarnea <sorin.sbarnea@gmail.com> Co-authored-by: Sorin Sbarnea <ssbarnea@redhat.com>
* Add utility to sync als version for devel CI job * Add python utility to copy ansible-language-server version to the vscode-ansible pacakage.json file for testing with main branch * fix ci failure * remove unwanted line
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Sorin Sbarnea <ssbarnea@redhat.com>
Devel pipeline is no longer needed because we always build ansible-language-server from inside the repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial: #1134
Related: https://issues.redhat.com/browse/AAP-21793