Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra whitespace after lightspeed suggestion #1163

Merged
merged 8 commits into from
Mar 29, 2024
Merged

Conversation

robinbobbitt
Copy link
Contributor

Currently when adding tasks via Lightspeed, the cursor is automatically indented in the following row to the appropriate column for the content of the task. However, it's expected that most likely a user is moving from prompt to prompt/task to task, rather than line by line manual development. As a result, they end up with a number of tasks with lines between them containing a bunch of whitespace, whereas ansible-lint expects them to be empty. This PR removes the extra whitespace. It also removes a stray vscode.commands.executeCommand("editor.action.inlineSuggest.trigger"); that should not have been in this function originally. This PR is most easily reviewed with whitespace ignored (?w=1).

Copy link
Collaborator

@TamiTakamiya TamiTakamiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one comment. Would you take a look?

Copy link
Collaborator

@TamiTakamiya TamiTakamiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ssbarnea ssbarnea changed the title remove extra whitespace after lightspeed suggestion Remove extra whitespace after lightspeed suggestion Mar 29, 2024
@ssbarnea ssbarnea enabled auto-merge (squash) March 29, 2024 14:48
@ssbarnea ssbarnea merged commit 5ab4c7a into main Mar 29, 2024
6 checks passed
@ssbarnea ssbarnea deleted the aap-21119 branch March 29, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants