-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove extra whitespace after lightspeed suggestion #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left one comment. Would you take a look?
TamiTakamiya
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ssbarnea
changed the title
remove extra whitespace after lightspeed suggestion
Remove extra whitespace after lightspeed suggestion
Mar 29, 2024
ssbarnea
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when adding tasks via Lightspeed, the cursor is automatically indented in the following row to the appropriate column for the content of the task. However, it's expected that most likely a user is moving from prompt to prompt/task to task, rather than line by line manual development. As a result, they end up with a number of tasks with lines between them containing a bunch of whitespace, whereas ansible-lint expects them to be empty. This PR removes the extra whitespace. It also removes a stray
vscode.commands.executeCommand("editor.action.inlineSuggest.trigger");
that should not have been in this function originally. This PR is most easily reviewed with whitespace ignored (?w=1
).