Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow use of ${workspaceFolder} in python.interpreterPath #1167

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Allow use of ${workspaceFolder} in python.interpreterPath #1167

merged 3 commits into from
Apr 18, 2024

Conversation

garymm
Copy link
Contributor

@garymm garymm commented Mar 26, 2024 •
edited

Related to #900

@garymm garymm requested a review from a team as a code owner March 26, 2024 23:10
@MLNW
Copy link

MLNW commented Apr 4, 2024

This would be great to have! Just spent at least an hour trying to set the interpreter through the workspaceFolder variable only to find issues stating that it is broken.

@priyamsahoo priyamsahoo added the bug Something isn't working label Apr 10, 2024
priyamsahoo
priyamsahoo approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@priyamsahoo priyamsahoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me apart from a very minor suggestion.
The PR needs to wait for a while before we merge it.
Thanks.

packages/ansible-language-server/src/utils/commandRunner.ts Outdated Show resolved Hide resolved
@garymm garymm requested a review from a team as a code owner April 10, 2024 17:29
garymm and others added 3 commits April 18, 2024 13:24
@garymm @ssbarnea
python.interpreterPath support ${workspaceFolder}
0ffc750 
Related to ansible#900
@garymm @priyamsahoo @ssbarnea
var -> let
a436ce0 
Co-authored-by: Priyam Sahoo <42550351+priyamsahoo@users.noreply.github.com>
@pre-commit-ci @ssbarnea
chore: auto fixes from pre-commit.com hooks
6d94273 
for more information, see https://pre-commit.ci
@ssbarnea ssbarnea changed the title python.interpreterPath support ${workspaceFolder} Allow use of ${workspaceFolder} in python.interpreterPath Apr 18, 2024
@ssbarnea ssbarnea merged commit 1f57768 into ansible:main Apr 18, 2024
12 of 13 checks passed
@garymm garymm deleted the garymm/interpreterPath branch April 18, 2024 16:28
@sgreiner sgreiner mentioned this pull request May 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

@priyamsahoo priyamsahoo priyamsahoo approved these changes

@Qalthos Qalthos Awaiting requested review from Qalthos Qalthos is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug Something isn't working
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@garymm @MLNW @ssbarnea @priyamsahoo