Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install collection in editable mode #1215

Merged
merged 10 commits into from
Apr 15, 2024
Merged

Install collection in editable mode #1215

merged 10 commits into from
Apr 15, 2024

Conversation

priyamsahoo
Copy link
Contributor

The PR:

  1. Adds feature to install collection in editable mode via a checkbox in the collection scaffolding webview (Resolves: [RFE] Add a check box in creator view to install collection in a editable way #1083).
  2. Updates the collection URL building logic in the webview based on this change in ansible-creator

@priyamsahoo priyamsahoo added bug Something isn't working feature New feature or request labels Apr 8, 2024
@priyamsahoo priyamsahoo requested review from a team as code owners April 8, 2024 10:05
ssbarnea
ssbarnea approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge after fixing the lint in another preparatory PR.

@priyamsahoo priyamsahoo merged commit ca1e64a into ansible:main Apr 15, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

@Qalthos Qalthos Awaiting requested review from Qalthos Qalthos is a code owner automatically assigned from ansible/devtools

@ganeshrn ganeshrn Awaiting requested review from ganeshrn

Assignees
No one assigned
Labels
bug Something isn't working feature New feature or request
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFE] Add a check box in creator view to install collection in a editable way
2 participants
@priyamsahoo @ssbarnea