Upgrade to eslint v9 #1223

ssbarnea · 2024-04-11T18:11:59Z

call eslint as a system hook instead of native pre-commit one
migrate eslint config to flat format
fix few new rules and temporary disable others

src/features/lightspeed/inlineSuggestions.ts

- call eslint as a system hook instead of native pre-commit one - upgrade eslint config - fix few new rules and temporary disable others

TamiTakamiya

As far as Lightspeed-related files concern, all looked good. Thank you.

ssbarnea temporarily deployed to ack April 11, 2024 18:12 — with GitHub Actions Inactive

ssbarnea had a problem deploying to ci April 11, 2024 18:12 — with GitHub Actions Error

ssbarnea temporarily deployed to ack April 11, 2024 18:12 — with GitHub Actions Inactive

github-actions bot added the skip-changelog label Apr 11, 2024

pre-commit-ci bot had a problem deploying to ci April 11, 2024 18:13 Failure

pre-commit-ci bot temporarily deployed to ack April 11, 2024 18:13 Inactive

ssbarnea force-pushed the chore/eslint branch from 61cb7e9 to 5d6a7f2 Compare April 11, 2024 18:40

ssbarnea had a problem deploying to ci April 11, 2024 18:41 — with GitHub Actions Error

ssbarnea temporarily deployed to ack April 11, 2024 18:41 — with GitHub Actions Inactive

pre-commit-ci bot had a problem deploying to ci April 11, 2024 18:42 Failure

pre-commit-ci bot had a problem deploying to ci April 11, 2024 18:42 Error

pre-commit-ci bot temporarily deployed to ack April 11, 2024 18:42 Inactive

ssbarnea requested a review from priyamsahoo April 11, 2024 18:43

ssbarnea force-pushed the chore/eslint branch from 55d356d to c4b4a12 Compare April 11, 2024 18:47

ssbarnea had a problem deploying to ci April 11, 2024 18:47 — with GitHub Actions Failure

ssbarnea had a problem deploying to ci April 11, 2024 18:47 — with GitHub Actions Error

ssbarnea temporarily deployed to ack April 11, 2024 18:47 — with GitHub Actions Inactive

ssbarnea temporarily deployed to ci April 12, 2024 11:58 — with GitHub Actions Inactive

ssbarnea temporarily deployed to ack April 12, 2024 11:58 — with GitHub Actions Inactive

TamiTakamiya reviewed Apr 12, 2024

View reviewed changes

src/features/lightspeed/inlineSuggestions.ts Show resolved Hide resolved

TamiTakamiya reviewed Apr 12, 2024

View reviewed changes

src/features/lightspeed/inlineSuggestions.ts Show resolved Hide resolved

ssbarnea force-pushed the chore/eslint branch from 2550212 to c2b6ee1 Compare April 12, 2024 13:25

ssbarnea temporarily deployed to ci April 12, 2024 13:25 — with GitHub Actions Inactive

ssbarnea had a problem deploying to ci April 12, 2024 13:25 — with GitHub Actions Failure

ssbarnea temporarily deployed to ci April 12, 2024 13:25 — with GitHub Actions Inactive

ssbarnea temporarily deployed to ack April 12, 2024 13:25 — with GitHub Actions Inactive

ssbarnea force-pushed the chore/eslint branch from c2b6ee1 to 62f9381 Compare April 12, 2024 13:39

ssbarnea temporarily deployed to ci April 12, 2024 13:39 — with GitHub Actions Inactive

ssbarnea temporarily deployed to ack April 12, 2024 13:39 — with GitHub Actions Inactive

ssbarnea requested a review from TamiTakamiya April 12, 2024 13:50

ssbarnea changed the title ~~Upgrade to eslint 9.0~~ Upgrade to eslint v9 Apr 12, 2024

Upgrade to eslint 9.0

2456268

- call eslint as a system hook instead of native pre-commit one - upgrade eslint config - fix few new rules and temporary disable others

ssbarnea force-pushed the chore/eslint branch from 62f9381 to 2456268 Compare April 12, 2024 14:02

ssbarnea temporarily deployed to ci April 12, 2024 14:02 — with GitHub Actions Inactive

ssbarnea temporarily deployed to ack April 12, 2024 14:02 — with GitHub Actions Inactive

priyamsahoo approved these changes Apr 12, 2024

View reviewed changes

TamiTakamiya approved these changes Apr 12, 2024

View reviewed changes

ssbarnea merged commit 259a975 into main Apr 12, 2024
8 of 10 checks passed

ssbarnea deleted the chore/eslint branch April 12, 2024 14:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to eslint v9 #1223

Upgrade to eslint v9 #1223

ssbarnea commented Apr 11, 2024 •

edited

TamiTakamiya left a comment

Upgrade to eslint v9 #1223

Upgrade to eslint v9 #1223

Conversation

ssbarnea commented Apr 11, 2024 • edited

TamiTakamiya left a comment

Choose a reason for hiding this comment

ssbarnea commented Apr 11, 2024 •

edited