-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support wait window setting for Lightspeed inline suggestion #1230
Merged
TamiTakamiya
merged 8 commits into
main
from
TamiTakamiya/inline-suggestion-wait-window-support
May 1, 2024
Merged
Support wait window setting for Lightspeed inline suggestion #1230
TamiTakamiya
merged 8 commits into
main
from
TamiTakamiya/inline-suggestion-wait-window-support
May 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TamiTakamiya
force-pushed
the
TamiTakamiya/inline-suggestion-wait-window-support
branch
from
April 16, 2024 19:52
cca8e51
to
f7b9253
Compare
TamiTakamiya
force-pushed
the
TamiTakamiya/inline-suggestion-wait-window-support
branch
from
April 16, 2024 20:00
f7b9253
to
944fd41
Compare
TamiTakamiya
force-pushed
the
TamiTakamiya/inline-suggestion-wait-window-support
branch
from
April 16, 2024 20:03
944fd41
to
d4d7867
Compare
priyamsahoo
approved these changes
May 1, 2024
TamiTakamiya
deleted the
TamiTakamiya/inline-suggestion-wait-window-support
branch
May 1, 2024 15:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For AAP-19633:
Add a wait window after a trigger (user pressing enter on matching the condition). If the user continues to type within the wait window the extension shouldn't send completion request.
The length of the wait window is configured using a new setting
ansible.lightspeed.suggestions.waitWindow
in milli-seconds. The default is set to 0, which let the extension send completion request immediately (=same as the current behavior).