Make hover e2e tests fixture messages more generic #934
+5
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyamsahoo
force-pushed
the
fix-e2e-tests-after-antsibull
branch
from
23dd1c3
to
2279955
Compare
priyamsahoo
force-pushed
the
fix-e2e-tests-after-antsibull
branch
from
2279955
to
67887e3
Compare
priyamsahoo
force-pushed
the
fix-e2e-tests-after-antsibull
branch
from
67887e3
to
7f43316
Compare
audgirka
approved these changes
Jun 28, 2023
ganeshrn
approved these changes
Jun 28, 2023
Merged
priyamsahoo
added a commit
that referenced
this pull request
Jul 28, 2023
## v2.5 ### Minor Changes - Upgrade als to v1.2.1 (#950) @priyamsahoo - Add ability to select and set cursor on vars following `_var_` pattern (#884) @priyamsahoo - Upgrade ALS to v1.1.0 (#932) @priyamsahoo - Upgrade yaml package to 2.x (#925) @priyamsahoo ### Bugfixes - Upgrade als to v1.2.1 (#950) @priyamsahoo - Fix command runner (#949) @priyamsahoo - Update lightspeed task name regex match condition (#947) (#948) @ganeshrn - Fix ansibleContent feedback event trigger (#940) @ganeshrn - Update runner.ts to correctly get the path of ansible (#945) @priyamsahoo - Make hover e2e tests fixture messages more generic (#934) @priyamsahoo for more information, see https://pre-commit.ci --------- Co-authored-by: Ansible DevTools <ansible-devtools@redhat.com> Co-authored-by: Priyam Sahoo <42550351+priyamsahoo@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
## v2.6 ### Minor Changes - Upgrade als to v1.2.1 (#950) @priyamsahoo - Add ability to select and set cursor on vars following `_var_` pattern (#884) @priyamsahoo - Upgrade yaml package to 2.x (#925) @priyamsahoo ### Bugfixes - Upgrade als to v1.2.1 (#950) @priyamsahoo - Fix command runner (#949) @priyamsahoo - Update lightspeed task name regex match condition (#947) (#948) @ganeshrn - Fix ansibleContent feedback event trigger (#940) @ganeshrn - Update runner.ts to correctly get the path of ansible (#945) @priyamsahoo - Make hover e2e tests fixture messages more generic (#934) @priyamsahoo
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes hover e2e tests fixture messages more generic for the assertion to avoid failures because of markdown syntax.