Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add state check when identifying corresponding CP mgmt and ngfw #425

Merged
merged 1 commit into from Sep 13, 2019
Merged

Add state check when identifying corresponding CP mgmt and ngfw #425

merged 1 commit into from Sep 13, 2019

Conversation

liquidat
Copy link
Contributor

SUMMARY

We need to add the NGFW to the MGMT server. To identify the two machines which belong to the same student we use ec2_facts. However, until now there could be a race condition if a workshop was deployed, tore down and re-deployed with the same name fast enough. In that case for each student there could be two NGFW or two MGMT, each time one without a public IP. That might led to error messages.

This commit adds a state filter to ensure we only find running machines.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • provisioner

@liquidat liquidat added the security-workshop for security workshop label Sep 13, 2019
@maxamillion
Copy link
Collaborator

👍

@IPvSean IPvSean merged commit ed507c9 into ansible:devel Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security-workshop for security workshop
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants