Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base-minimal: Clean env when static-ansible #32

Closed
wants to merge 1 commit into from

Conversation

Spredzy
Copy link
Collaborator

@Spredzy Spredzy commented Oct 8, 2018

No description provided.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@pabelanger
Copy link
Contributor

This is a good start, but something we need to consider here, is all job / projects use base-minimal. So, adding per project setting here isn't going to scale well IMO. For this specific case, I think we can do a few things.

We should can create a new job, say awx-base, as untrusted, that is zuul-jobs. have it parent to base (which is also untrusted). Then, in the post-run logic, after log collections, we can add logic to clean up static nodes. In zuul, we've also discussed the idea of a clean up handler, but don't think it is landed.

2nd, we shouldn't be modifying base-minimal directly, we should first propose this to base-minimal-test, as not to break the world. Again, since everything uses this base job, we need to first properly ensure it is tested via base-minimal-test before promoting to base-minimal.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@Spredzy Spredzy closed this Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants