-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugs... #13
Comments
Hi, Thanks for pointing out the issues. We will look into the issues and fix them and make sure that it does not happen again in future :D Some immediate clarifications I would like to make are the following -
|
他们模型的bug真的很多,他们的代码和thunlp的GPGNN是很相似的,如果你在训练中遇到了indices没有定义的问题,可以看看GPGNN的test.py |
感谢,不过经过我几天的修改,他们代码的所有bug基本都被我修复了,甚至还加了本来应该有的很多功能及评估指标。 |
同学你好,请问可不可以分享一下你的相关代码?如果不方便的话可不可以细说一下添加的相关功能和评估指标 |
当然可以,这两天我会把相关代码分享出来。 |
Hi @Caesar-s1mple I've translated your comment and if I'm right you said you would have uploaded the fixed code in two days? It would really help me a bug fixed version of this code, if you want you can contact me to the e-mail shown on my profile! ^^ |
您好,请问您可以放一下您的代码嘛?我被这个代码困扰很久了 |
同学您好,可以公布一下您的代码嘛?我弄了一个月了都没有跑通,可不可以联系一下我。1453646213@qq.com |
Hello, after serveral days of debugging, I have found many bugs in your code.
I'd like to share them with other people, and I hope you can fix them.
(1)Tons of file path errors which I don't want to list here.
(2)models/models.py
Why you use nn.Parameter to create 'init_gat_relation_embeddings' here? Moreover, why you set 'requires_grad=True'?
(3)GAT_seq_space/main.py
'outfolder' is not defined...^^
I don't know why you write these.
The proper code is
the same bug also exists on many other lines...
(4)train.py
Too many...I just wanna list some of them
Code here is not complete, resulting a lot of 'not defined' errors.
I know it's not a big deal, but I seems to prove that your code is ..... :(
(5)Tons of other bugs that I have fixed and forgotten
Thanks a lot if you can fix them all :)
And it will be more thankful if you can write CLEARLY how to run your code in README.md 👍
The text was updated successfully, but these errors were encountered: