[Fix] Function name collision with Actions Pack Plugin #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahularyan
requested changes
Feb 13, 2024
includes/functions.php
Outdated
| */ | ||
| function ap_verify_nonce( $action ) { | ||
| return wp_verify_nonce( ap_sanitize_unslash( '__nonce', 'p' ), $action ); | ||
| if ( ! function_exists( 'ap_verify_nonce' ) ) { |
There was a problem hiding this comment.
@mebishalnapit Unfortunately, integrating other plugin functions here isn't feasible. It poses a risk of disrupting our ajax actions. To address this, we'll need to deprecate the current function and introduce a new one, anspress_verify_nonce. Then, we'll have to systematically replace all instances of calls to the ap_verify_nonce function throughout our plugin.
There was a problem hiding this comment.
@rahularyan Done.
rahularyan
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
ap_verify_noncefunction