[Fix] Max upload size plugin option can exceed the value to be set inside it more than max_upload_size php.ini settings #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add - Introduce a filter before modifying the plugin options data before it is ready to be saved Add - Filter the max_upload_size options data to not add the option for it greater than max_upload_size php derivative Tweak - Set maximum upload size string modify to enter value in bytes
rahularyan
requested changes
Feb 21, 2024
There was a problem hiding this comment.
@mebishalnapit We have to do this without a hook. As this is a core logic and hence we don't want to do this using a hook.
|
@rahularyan Modified without using filter hook. |
rahularyan
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes: