[Fix] Option: prevent thrashing question if there are any answers #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahularyan
requested changes
Feb 22, 2024
includes/theme.php
Outdated
| @@ -289,7 +289,16 @@ function ap_post_actions( $_post = null ) { | |||
| $actions[] = array( 'header' => true ); | |||
| } | |||
|
|
|||
| if ( ap_user_can_delete_post( $_post->ID ) ) { | |||
| $answers = get_posts( | |||
There was a problem hiding this comment.
@mebishalnapit Why you need to load all posts here? Can't we simply get a count?
There was a problem hiding this comment.
@rahularyan wp_count_posts will not work on this condition since it will count all of the available answers throughout the site while in this case, we'll only need the answers related to a specific question.
There was a problem hiding this comment.
Try this: ap_count_published_answers
There was a problem hiding this comment.
Done and also resolved conflicts.
rahularyan
requested changes
Feb 23, 2024
includes/theme.php
Outdated
| if ( ap_user_can_delete_post( $_post->ID ) ) { | ||
| $answers = ap_count_published_answers( $_post->ID ); | ||
|
|
||
| if ( ap_user_can_delete_post( $_post->ID ) && ( ! ap_opt( 'trashing_question_with_answer' ) || ( ap_opt( 'trashing_question_with_answer' ) && empty( $answers ) ) ) ) { |
There was a problem hiding this comment.
@mebishalnapit Can this be simplified to this:
if (ap_user_can_delete_post($_post->ID) && (!ap_opt('trashing_question_with_answer') || empty($answers))) {
There was a problem hiding this comment.
@rahularyan Modified the condition as requested.
rahularyan
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes: