Quick fix for installation issues #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… repo which breaks c++11 compilation. This hard-codes a direct download to boost version 1.73.0. 2. Hard-coded the versions of petsc4py and slepc4py that are retrieved in setup.py to fix an incompatibility with the versions of petsc and slepc that were installed from source in install.py. An alternate installation scheme might be preferable, but works for now. 3. Minor bug fix in emopt/fdtd.py to correct the w_pml setter
|
Thanks for the fixes. In the future, I think I will do away with install_deps.py all together. Instead, compatible versions of boost and eigen can now be installed from pretty much all of the mainstream linux package managers. We will rely on petsc4py and slepc4py to compile PETSc and SLEPc. Ill implement and test on the develop branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on CentOS 7 with Python 2.7 and Python 3.8