Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new canonical link action #425

Merged
merged 4 commits into from
Mar 20, 2024
Merged

feat: new canonical link action #425

merged 4 commits into from
Mar 20, 2024

Conversation

jorgepiloto
Copy link
Member

This pull-request includes a new reusable private action named _doc-gen-canonical. Its goal is to ensure that the <link rel="canonical" href="..." /> is included in any HTML of the version/stable directory.

@jorgepiloto jorgepiloto requested a review from a team as a code owner March 14, 2024 14:55
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@jorgepiloto jorgepiloto changed the base branch from main to feat/seo-improvements March 14, 2024 14:55
@wiz-inc-572fc38784
Copy link

wiz-inc-572fc38784 bot commented Mar 14, 2024 •
edited

Wiz Scan Summary
IaC Misconfigurations 0C 0H 0M 0L 0I
Vulnerabilities 0C 0H 0M 0L 0I
Sensitive Data 0C 0H 0M 0L 0I
Total 0C 0H 0M 0L 0I
Secrets 0🔑

@github-actions github-actions bot added the enhancement New features or code improvements label Mar 14, 2024
Revathyvenugopal162
Revathyvenugopal162 approved these changes Mar 14, 2024
View reviewed changes
_doc-gen-canonical/action.yml Outdated Show resolved Hide resolved
@RobPasMue @Revathyvenugopal162
Update _doc-gen-canonical/action.yml
6e3dff9 
Co-authored-by: Revathy Venugopal <104772255+Revathyvenugopal162@users.noreply.github.com>
@jorgepiloto jorgepiloto added the blocked Cannot address this till other issues are solved first label Mar 15, 2024
@jorgepiloto jorgepiloto marked this pull request as draft March 15, 2024 07:13
@jorgepiloto
Copy link
Member Author

Converting this to draft and blocking it. I just want to prevent any modifications in the HTML pages for geometry before we get the latest results on SEO improvements.

@jorgepiloto jorgepiloto marked this pull request as ready for review March 18, 2024 09:17
@jorgepiloto jorgepiloto marked this pull request as draft March 18, 2024 09:17
@jorgepiloto
Copy link
Member Author

It looks like Google prefers the project.docs.pyansys.com as the canonical URL for the /version/stable/index.html page.

@jorgepiloto jorgepiloto marked this pull request as ready for review March 20, 2024 08:56
@jorgepiloto jorgepiloto merged commit ab9cad7 into feat/seo-improvements Mar 20, 2024
16 checks passed
@jorgepiloto jorgepiloto deleted the feat/canonical branch March 20, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

@Revathyvenugopal162 Revathyvenugopal162 Revathyvenugopal162 approved these changes

Assignees
No one assigned
Labels
blocked Cannot address this till other issues are solved first enhancement New features or code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jorgepiloto @RobPasMue @Revathyvenugopal162