Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration between STK and BoM Analytics #9

Open
Andy-Grigg opened this issue Nov 17, 2021 · 2 comments
Open

Integration between STK and BoM Analytics #9

Andy-Grigg opened this issue Nov 17, 2021 · 2 comments
Labels
enhancement New features or code improvements

Comments

@Andy-Grigg
Copy link
Collaborator

There needs to be some interop between STK objects and this package, but we don't want to use the heavyweight STK objects directly.

Implement a lightweight coupling between the STK and this package in the form of python dicts / JSON string.

Some other thoughts:

  • Some sort of decorator that checks argument type?
  • Avoid isinstance, can we do something with dict or slots?
@Andy-Grigg
Copy link
Collaborator Author

This is implemented as much as possible from the PyAnsys side, in that a dict of GUIDs and DBKeys can be provided when building a query. Will require a more coordinated effort between this package and STK to do something more joined up.

@Andy-Grigg Andy-Grigg added the enhancement New features or code improvements label Nov 17, 2021
@Andy-Grigg
Copy link
Collaborator Author

Some thought needs to be given to how we set a non-standard db key and tables in this package.

Andy-Grigg pushed a commit that referenced this issue Jan 11, 2024
FIX - Remove codecov upload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

No branches or pull requests

1 participant