Lightfield sensor and source #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add source base class add lightfield class with source as base
StefanThoene
requested changes
Dec 12, 2022
There was a problem hiding this comment.
Hi @BenoitHeraud create ground work done here here some comments about adjustments and changes please feel free to schedule a meeting
|
|
||
| Parameters | ||
| ---------- | ||
| incident_resolution : int, optionl |
There was a problem hiding this comment.
this hsould be a float as it can be 0.5 degree
| speos_object = self.speos_sim.SensorLightField.Create() | ||
| speos_object.Name = name | ||
| self.speos_object = speos_object | ||
|
|
There was a problem hiding this comment.
You are missing the wavelength settings -> start end+ res
|
|
||
| def append_source(simulation_name): | ||
| """ | ||
| Append a list of source in a simulation. |
There was a problem hiding this comment.
please add correct doc string
| """ | ||
| speos_source_list = [] | ||
| for items in GetRootPart().CustomObjects: | ||
| if items.Type == "SPEOS_SC.SIM.SpeosWrapperSourceSurface": |
There was a problem hiding this comment.
please use correct speos API
Suggested change
| if items.Type == "SPEOS_SC.SIM.SpeosWrapperSourceSurface": | |
| if SpeosSim.SourceSurface.Find(items.GetName()): |
|
|
||
| class SourceLightField(Source): | ||
| """ | ||
| Provides methods for defining the Speos LocalMeshing. |
There was a problem hiding this comment.
Please adjust docstring
| super(Source, self).__init__(SpaceClaim, ["V19", "V20", "V21", "V22", "V23"]) | ||
| self.speos_sim = SpeosSim | ||
| self.name = name | ||
| self.speos_object = None |
There was a problem hiding this comment.
maybe add some values all sources have in comon E.g. Power, spectrum, intensity type ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.