-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lightfield sensor and source #123
Conversation
add source base class add lightfield class with source as base
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @BenoitHeraud create ground work done here here some comments about adjustments and changes please feel free to schedule a meeting
|
||
Parameters | ||
---------- | ||
incident_resolution : int, optionl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this hsould be a float as it can be 0.5 degree
speos_object = self.speos_sim.SensorLightField.Create() | ||
speos_object.Name = name | ||
self.speos_object = speos_object | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are missing the wavelength settings -> start end+ res
|
||
def append_source(simulation_name): | ||
""" | ||
Append a list of source in a simulation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add correct doc string
""" | ||
speos_source_list = [] | ||
for items in GetRootPart().CustomObjects: | ||
if items.Type == "SPEOS_SC.SIM.SpeosWrapperSourceSurface": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use correct speos API
if items.Type == "SPEOS_SC.SIM.SpeosWrapperSourceSurface": | |
if SpeosSim.SourceSurface.Find(items.GetName()): |
|
||
class SourceLightField(Source): | ||
""" | ||
Provides methods for defining the Speos LocalMeshing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please adjust docstring
super(Source, self).__init__(SpaceClaim, ["V19", "V20", "V21", "V22", "V23"]) | ||
self.speos_sim = SpeosSim | ||
self.name = name | ||
self.speos_object = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add some values all sources have in comon E.g. Power, spectrum, intensity type ...
No description provided.