Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
  • Loading branch information
3 people committed Apr 26, 2024
1 parent e560c24 commit 0f34d79
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 11 deletions.
8 changes: 4 additions & 4 deletions _unittest/test_21_Circuit.py
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ def test_19b_create_eye_setups(self):
assert self.aedtapp.create_setup(setup_name, "NexximAMI")

@pytest.mark.skipif(
is_linux and config["desktopVersion"] == "2024.1", reason="Project with multiple Circuit designs not valid"
is_linux and config["desktopVersion"] == "2024.1", reason="Project with multiple circuit designs is not working."
)
def test_20a_create_ami_plots(self, add_app):
ami_design = add_app(ami_project, design_name="Models Init Only", application=Circuit, subfolder=test_subfolder)
Expand Down Expand Up @@ -792,7 +792,7 @@ def test_43_create_and_change_prop_text(self):
assert self.aedtapp.modeler.create_text("text test", "1000mil", "-2000mil")

@pytest.mark.skipif(config["NonGraphical"], reason="Change property doesn't work in non-graphical mode.")
@pytest.mark.skipif(is_linux and config["desktopVersion"] == "2024.1", reason="Schematic has to closed.")
@pytest.mark.skipif(is_linux and config["desktopVersion"] == "2024.1", reason="Schematic has to be closed.")
def test_44_change_text_property(self):
self.aedtapp.set_active_design("text")
text_id = self.aedtapp.oeditor.GetAllGraphics()[0].split("@")[1]
Expand All @@ -806,7 +806,7 @@ def test_44_change_text_property(self):
assert not self.aedtapp.modeler.change_text_property(text_id, "Invalid", {})

@pytest.mark.skipif(config["NonGraphical"], reason="Change property doesn't work in non-graphical mode.")
@pytest.mark.skipif(is_linux and config["desktopVersion"] == "2024.1", reason="Schematic has to closed.")
@pytest.mark.skipif(is_linux and config["desktopVersion"] == "2024.1", reason="Schematic has to be closed.")
def test_45_create_circuit_from_multizone_layout(self, add_edb):
edb = add_edb(project_name="multi_zone_project")
common_reference_net = "gnd"
Expand Down Expand Up @@ -855,7 +855,7 @@ def test_47_automatic_lna(self):
)
assert status

@pytest.mark.skipif(config["NonGraphical"] and is_linux, reason="Method not working in Linux and Non graphical")
@pytest.mark.skipif(config["NonGraphical"] and is_linux, reason="Method is not working in Linux and non-graphical mode.")
def test_48_automatic_tdr(self):
touchstone_file = os.path.join(local_path, "example_models", test_subfolder, touchstone_custom)

Expand Down
2 changes: 1 addition & 1 deletion _unittest/test_22_Circuit_DynamicLink.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ def test_05_set_sim_option_on_hfss_subcircuit(self):
assert self.aedtapp.modeler.schematic.set_sim_option_on_hfss_subcircuit(hfss_comp, option="interpolate")
assert not self.aedtapp.modeler.schematic.set_sim_option_on_hfss_subcircuit(hfss_comp, option="not_good")

@pytest.mark.skipif(is_ironpython, reason="Skipped because Desktop is crashing")
@pytest.mark.skipif(is_ironpython, reason="Skipped because AEDT is crashing.")
@pytest.mark.skipif(config["NonGraphical"] and is_linux, reason="Method not working in Linux and Non graphical")
def test_06_set_sim_solution_on_hfss_subcircuit(self):
hfss_comp = "CompInst@uUSB;87;3"
Expand Down
4 changes: 2 additions & 2 deletions _unittest/test_28_Maxwell3D.py
Original file line number Diff line number Diff line change
Expand Up @@ -869,8 +869,8 @@ def test_53_assign_layout_force(self, layout_comp):
nets_layers = {"1V0": "Bottom Solder"}
assert layout_comp.assign_layout_force(nets_layers, "LC1_1")

@pytest.mark.skipif(desktop_version < "2023.2" or is_linux, reason="Method available in beta from 2023.2")
@pytest.mark.skipif(is_linux, reason="EDB object is not loaded")
@pytest.mark.skipif(desktop_version < "2023.2" or is_linux, reason="Method is available in beta in 2023.2 and later.")
@pytest.mark.skipif(is_linux, reason="EDB object is not loaded.")
def test_54_enable_harmonic_force_layout(self, layout_comp):
comp = layout_comp.modeler.user_defined_components["LC1_1"]
layers = list(comp.layout_component.layers.keys())
Expand Down
2 changes: 1 addition & 1 deletion _unittest/test_41_3dlayout_modeler.py
Original file line number Diff line number Diff line change
Expand Up @@ -654,7 +654,7 @@ def test_41_test_create_polygon(self):

@pytest.mark.skipif(not config["use_grpc"], reason="Not running in COM mode")
@pytest.mark.skipif(config["desktopVersion"] < "2023.2", reason="Working only from 2023 R2")
@pytest.mark.skipif(is_linux, reason="PyEDB failing in Linux")
@pytest.mark.skipif(is_linux, reason="PyEDB is failing in Linux.")
def test_42_post_processing(self, add_app):
test_post1 = add_app(project_name=test_post, application=Maxwell3d, subfolder=test_subfolder)
assert test_post1.post.create_fieldplot_layers(
Expand Down
2 changes: 1 addition & 1 deletion _unittest_solvers/test_00_analyze.py
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ def test_07_export_maxwell_fields(self, m3dtransient):
new_setup.props = setup.props
new_setup.update()

@pytest.mark.skipif(is_linux, reason="SPISIM not working in linux.")
@pytest.mark.skipif(is_linux, reason="SPISIM is not working in Linux.")
def test_08_compute_erl(self, circuit_erl):
touchstone_file = circuit_erl.export_touchstone()
spisim = SpiSim(touchstone_file)
Expand Down
2 changes: 1 addition & 1 deletion pyaedt/application/Design.py
Original file line number Diff line number Diff line change
Expand Up @@ -3333,7 +3333,7 @@ def _insert_design(self, design_type, design_name=None):
if new_design is None: # pragma: no cover
new_design = self.desktop_class.active_design(self.oproject, unique_design_name, self.design_type)
if new_design is None:
self.logger.error("Fail to create new design.")
self.logger.error("Failed to create design.")
return
self.logger.info("Added design '%s' of type %s.", unique_design_name, design_type)
name = new_design.GetName()
Expand Down
2 changes: 1 addition & 1 deletion pyaedt/desktop.py
Original file line number Diff line number Diff line change
Expand Up @@ -720,7 +720,7 @@ def active_design(self, project_object, name=None, design_type=None):
AEDT project object.
name : str, optional
Name of the active design to make active.
Name of the design to make active.
The default is ``None``, in which case the active design is returned.
design_type : str, optional
Expand Down

0 comments on commit 0f34d79

Please sign in to comment.