New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/export import existing hfss3dlayout setup #2594
Bug/export import existing hfss3dlayout setup #2594
Conversation
Hi @isaacansys I think the two approaches proposed by you are not excluding each other. I'm working to a potential fix for point 1 while we could make the import_from_json more tolerant during the import phase. |
@isaacansys please give a look to the modifications I've pushed and let me know if you agree on this approach |
Codecov Report
@@ Coverage Diff @@
## main #2594 +/- ##
==========================================
- Coverage 80.16% 80.14% -0.03%
==========================================
Files 164 163 -1
Lines 53136 53070 -66
==========================================
- Hits 42599 42533 -66
Misses 10537 10537 |
Add a test for exporting and importing a setup from an existing HFSS 3D Layout design with an existing setup. This currently fails.
Add example projects and extend the test case for #2593 to be version specific for 2022.1, 2022.2, and 2023.1.
…ort_from_json is now tolerant on wrong keys.
…ort_from_json is now tolerant on wrong keys.
Now that set_props will issue a warning instead of throwing an exception when it encounters a new property key, if the value is a dictionary we need to initialize the key to an empty dictionary before recursing.
5456530
to
5a8cf3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Updates SetupTemplates.HFSS3DLayout and child templates to 2023 R1 and adds a test for export/import round trip from an existing HFSS 3D Layout design and setup, which would fail prior to this fix (e.g. at 5eb876d). Reasons for draft status:
Fixes #2593