Bug 3386 patch example update #3566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assert should not be used in productive code.
Allow material to be cloned and parameterized.
AEDT throws a strange error when creating the patch.
AEDT throws a strange error when creating the patch.
Conductors with parametric conductivitiy were always returned as dielectrics.
filesystem.Scratch.copyfile()
FileNotFoundError if the path passed to Scratch() doesn't exist.
Added some comments and improved docstrings to help understand the code.
Method str_to_bool added to DataHandlers.py use map() to convert strings to Boolean when the diff pair arguments are passed to EditDiffPairs in Hfss in the method `set_differential_pair`
Adopted suggestions from @PipKat.
# Conflicts: # examples/02-HFSS/Machine_learning_applied_to_Patch.py
Use the Stackup3D class. Note that the original ML Patch example had to be removed.
PipKat
reviewed
Sep 18, 2023
PipKat
reviewed
Sep 18, 2023
Resolved inconsistencies in the way dielectric properties are handled.
Simplify assignment of sr for choke.
MaxJPRey
reviewed
Sep 20, 2023
MaxJPRey
reviewed
Sep 20, 2023
MaxJPRey
reviewed
Sep 20, 2023
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
for more information, see https://pre-commit.ci
maxcapodi78
approved these changes
Sep 21, 2023
pyaedt/application/Analysis.py
Outdated
| @@ -178,6 +178,8 @@ def materials(self): | |||
| Materials in the project. | |||
|
|
|||
| """ | |||
|
|
|||
| # Instantiate an instance of self._materials the first time it is accessed. | |||
There was a problem hiding this comment.
you can move this comment into the property description.
Co-authored-by: Massimo Capodiferro <77293250+maxcapodi78@users.noreply.github.com>
Co-authored-by: Massimo Capodiferro <77293250+maxcapodi78@users.noreply.github.com>
Co-authored-by: Massimo Capodiferro <77293250+maxcapodi78@users.noreply.github.com>
|
Add probe-fed patch example.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stackup3Dwill no longer be set to "solve inside." (Bug setting Solve Inside when material is a frequency dependent dielectric #3386, Bug located in Stackup3D #2977)