Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Pythonnet to allow usage with python3.12 #3753

Merged
merged 5 commits into from
Oct 23, 2023

Conversation

FranzForstmayr
Copy link
Contributor

This Patch Bumps pythonnet to 3.0.3 which allows to install it on python3.12

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@maxcapodi78
Copy link
Collaborator

@FranzForstmayr @SMoraisAnsys we need to check if we have to use ansys-pythonnet or pythonnet.

@MaxJPRey
Copy link
Collaborator

@FranzForstmayr @SMoraisAnsys we need to check if we have to use ansys-pythonnet or pythonnet.

@maxcapodi78 Yes, it is pending 😃 .

@SMoraisAnsys
Copy link
Collaborator

Talks should happen today about using https://github.com/ansys/ansys-pythonnet (and updating it to reach pythonnet 3.0.3 changes) or switch to pythonnet original repo

@FranzForstmayr
Copy link
Contributor Author

Any updates? Or should I close this PR?

@SMoraisAnsys
Copy link
Collaborator

Any updates? Or should I close this PR?

Don't close it. I'm sorry for not coming back, I had to focus on other stuff this days.
I should talk with @koubaa tomorrow and should be able to give you an answer afterward :)

@SMoraisAnsys
Copy link
Collaborator

SMoraisAnsys commented Oct 20, 2023

A year ago a fork of pythonnet was created (https://github.com/ansys/ansys-pythonnet) because there were changes that made it difficult to work around pymechanical.
This fork is almost equal to the original repo (https://github.com/pythonnet/pythonnet) except for :

Changes relative to pythonnet: - Revert of https://github.com/pythonnet/pythonnet/pull/1240.
- Enum REPR #2239 <https://github.com/pythonnet/pythonnet/pull/2239> is included in this release of version 3.0.2, but is unreleased in pythonnet

As we are trying to have a set of common packages for Ansys products, I would prefer using Ansys's fork. It is not yet up to date but should be soon as a PR (ansys/ansys-pythonnet#13) merges changes from pythonnet 3.0.3
When the ansys-pythonnet PR is accepted, could you update this PR to use the right ansys-pythonnet version ?

@SMoraisAnsys
Copy link
Collaborator

@FranzForstmayr Thanks for the modifications. Could you try the new release ansys-pythonnet==v3.1.0-rc3 (v3.1.0-rc3 ) ?
This release should be up to date with pythonnet except for the commit reverted :)

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SMoraisAnsys SMoraisAnsys merged commit 05934ce into ansys:main Oct 23, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants