Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/issue 3260 #3782

Merged
merged 5 commits into from
Oct 23, 2023
Merged

Fix/issue 3260 #3782

merged 5 commits into from
Oct 23, 2023

Conversation

lorenzovecchietti
Copy link
Collaborator

@lorenzovecchietti lorenzovecchietti commented Oct 23, 2023

Close #3260

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Oct 23, 2023
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #3782 (75c8ee1) into main (7947d1c) will increase coverage by 0.00%.
Report is 8 commits behind head on main.
The diff coverage is 89.65%.

@@           Coverage Diff           @@
##             main    #3782   +/-   ##
=======================================
  Coverage   81.07%   81.08%           
=======================================
  Files         180      180           
  Lines       61961    61977   +16     
=======================================
+ Hits        50234    50252   +18     
+ Misses      11727    11725    -2     

@lorenzovecchietti lorenzovecchietti merged commit 44d83df into main Oct 23, 2023
12 checks passed
@lorenzovecchietti lorenzovecchietti deleted the fix/issue_3260 branch October 23, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icepak.export_summary(output_dir, type='Boundary', geometryType='Volume') doesn't exclude PCB and air region
2 participants