Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminal enhancement #3795

Merged
merged 17 commits into from
Oct 26, 2023
Merged

terminal enhancement #3795

merged 17 commits into from
Oct 26, 2023

Conversation

ring630
Copy link
Collaborator

@ring630 ring630 commented Oct 25, 2023

new method to place probe between two points

self.edbapp.siwave.place_voltage_probe(
            "vprobe_2", "1V0", ["112mm", "24mm"], "1_Top", "GND", ["112mm", "27mm"], "Inner1(GND1)"
        )

new class
PointTerminal
PinGroupTerminal

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the edb label Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #3795 (6d00ec2) into main (bb3830c) will increase coverage by 0.01%.
The diff coverage is 92.77%.

@@            Coverage Diff             @@
##             main    #3795      +/-   ##
==========================================
+ Coverage   81.06%   81.08%   +0.01%     
==========================================
  Files         180      180              
  Lines       62067    62140      +73     
==========================================
+ Hits        50315    50385      +70     
- Misses      11752    11755       +3     

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ring630 Please change the pragma no cover at "if" level, it does not work inside. Thanks!

pyaedt/edb_core/edb_data/terminals.py Outdated Show resolved Hide resolved
pyaedt/edb_core/edb_data/terminals.py Outdated Show resolved Hide resolved
ring630 and others added 4 commits October 26, 2023 13:58
Co-authored-by: Samuel Lopez <85613111+Samuelopez-ansys@users.noreply.github.com>
Co-authored-by: Samuel Lopez <85613111+Samuelopez-ansys@users.noreply.github.com>
@ring630
Copy link
Collaborator Author

ring630 commented Oct 26, 2023

@SMoraisAnsys this is EDB related.

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys merged commit 7eae896 into main Oct 26, 2023
12 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the port_source_enhancement branch October 26, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants