Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blower bc function #3872

Merged
merged 23 commits into from
Nov 14, 2023
Merged

Add blower bc function #3872

merged 23 commits into from
Nov 14, 2023

Conversation

lorenzovecchietti
Copy link
Collaborator

Close #3871

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@codecov Codecov
Copy link

codecov bot commented Nov 13, 2023 •
edited

Codecov Report

Merging #3872 (43e82ef) into main (94e72ee) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 88.63%.

❗ Current head 43e82ef differs from pull request most recent head 5dbbd34. Consider uploading reports for the commit 5dbbd34 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3872   +/-   ##
=======================================
  Coverage   81.27%   81.27%           
=======================================
  Files         182      182           
  Lines       62747    62793   +46     
=======================================
+ Hits        50995    51038   +43     
- Misses      11752    11755    +3

@lorenzovecchietti lorenzovecchietti marked this pull request as draft November 13, 2023 11:08
Samuelopez-ansys
Samuelopez-ansys reviewed Nov 13, 2023
View reviewed changes
pyaedt/icepak.py Outdated Show resolved Hide resolved
pyaedt/icepak.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Nov 13, 2023
View reviewed changes
pyaedt/icepak.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Nov 13, 2023
View reviewed changes
pyaedt/icepak.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Nov 13, 2023
View reviewed changes
pyaedt/icepak.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Nov 13, 2023
View reviewed changes
pyaedt/icepak.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Nov 13, 2023
View reviewed changes
pyaedt/icepak.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Nov 13, 2023
View reviewed changes
pyaedt/icepak.py Outdated Show resolved Hide resolved
@lorenzovecchietti lorenzovecchietti marked this pull request as ready for review November 14, 2023 10:50
Samuelopez-ansys
Samuelopez-ansys approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pyaedt/icepak.py Outdated Show resolved Hide resolved
pyaedt/icepak.py Outdated Show resolved Hide resolved
@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) November 14, 2023 10:53
@Samuelopez-ansys Samuelopez-ansys merged commit ddcc3d7 into main Nov 14, 2023
11 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the Enhancement/blower_bc branch November 14, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PipKat PipKat PipKat left review comments

@Samuelopez-ansys Samuelopez-ansys Samuelopez-ansys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Blower Boundary
3 participants
@lorenzovecchietti @PipKat @Samuelopez-ansys