Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example fixed #4007

Merged
merged 36 commits into from
Dec 22, 2023
Merged

Example fixed #4007

merged 36 commits into from
Dec 22, 2023

Conversation

svandenb-dev
Copy link
Collaborator

Example release fixed

# Conflicts:
#	pyaedt/edb_core/edb_data/primitives_data.py
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) December 22, 2023 15:41
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f0af285) 81.42% compared to head (94283a5) 78.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4007      +/-   ##
==========================================
- Coverage   81.42%   78.81%   -2.61%     
==========================================
  Files         182      182              
  Lines       63306    63306              
==========================================
- Hits        51544    49894    -1650     
- Misses      11762    13412    +1650     

@Samuelopez-ansys Samuelopez-ansys merged commit 9da6cb5 into main Dec 22, 2023
12 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the example_fixed branch December 22, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants