Improve convert via to 3d #4028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4028 +/- ##
==========================================
+ Coverage 81.47% 81.63% +0.16%
==========================================
Files 182 182
Lines 63565 63546 -19
==========================================
+ Hits 51787 51877 +90
+ Misses 11778 11669 -109 |
PipKat
reviewed
Jan 4, 2024
PipKat
reviewed
Jan 4, 2024
MaxJPRey
reviewed
Jan 5, 2024
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Add check to exclude padstack definition using hole shape poly. I tried to use a check on self.hole_type == "NoGeometry" as it does not work I check len(self.hole_properties) which is 0 for hole shape poly and greater than 0 for all other hole shape
|
Could you check my last commit it seems there is a modification on file Design.py but it is not coming from me. |
Modify C:\ANSYSDEV\NoBackup\pyaedt\_unittest\example_models\TEDB\padstacks.aedb to add 4 padstack definitions with different hole shape. Modify test_128_microvias to add test when padstack definition is preserved and test padstack with different hole shape.
Fix issues on test_128_microvias
for more information, see https://pre-commit.ci
PipKat
reviewed
Jan 8, 2024
PipKat
reviewed
Jan 8, 2024
Fix issues on test_128_microvias
Update test_128_microvias with assert not for hole shpae poly
…erent from layer name.
2 tasks
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve convert via to 3D.
Add the ability to not remove the padstack definition and to set hole size to zero.